Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2496) fix error routes on forms #2575

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

LuccaBitfly
Copy link
Collaborator

@LuccaBitfly LuccaBitfly commented Sep 26, 2023

Removing the mobile form was approved

🤖 Generated by Copilot at c9fbe9f

This pull request removes the app pool support feature from the /mobile endpoint and the mobilepage.html template, as it was unused and irrelevant. It also improves the error logging and fixes a bug for the ad inquiry feature in the /handlers/advertisewithus.go and /handlers/pricing.go files.

Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket itself has been properly tackled. I have spotted a related issue though, please see my comment below.

Comment on lines 69 to 71
err = mail.SendTextMail("support@beaconcha.in", "New ad inquiry", msg, []types.EmailAttachment{})
err = mail.SendTextMail("inquiries@beaconcha.in", "New ad inquiry", msg, []types.EmailAttachment{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have discussed this with @Buttaa: Having our own mail address hardcoded within the sources makes the explorer unusable for other people.

Please make this mail address configurable via the config. Please check for other mail addresses too.

Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LuccaBitfly LuccaBitfly merged commit 2a5ba87 into master Oct 2, 2023
3 checks passed
@LuccaBitfly LuccaBitfly deleted the BIDS-2496/fixFormErrorRoutes branch October 2, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants