(BIDS-2440) improve withrdawals page perf #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisei24
reviewed
Sep 5, 2023
db/db.go
Outdated
| FROM blocks_withdrawals w | ||
| INNER JOIN blocks b ON w.block_root = b.blockroot AND b.status = '1' | ||
| %s | ||
| ORDER BY w.block_slot DESC |
There was a problem hiding this comment.
question: Why do we need an ORDER BY if we only count the results?
There was a problem hiding this comment.
you are right this is not needed, updated
recy21
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 93c852c
This pull request improves the handling of withdrawals and BLS changes in the
dbandhandlerspackages by introducing and using constants for query limits. This enhances the code quality, performance, and accuracy of the queries.