Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2432) Remove text-primary style from 0x in FormatAddressLong #2530

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

D13ce
Copy link
Contributor

@D13ce D13ce commented Sep 5, 2023

This PR causes the 0x prefix of address not to be color orange anymore.

Current example: https://prater.beaconcha.in/address/0xe6a651e0a30fda0dc7f8b709287f5b76e0109202
image

This PR replaces #2522.

utils/eth1.go Outdated Show resolved Hide resolved
utils/eth1.go Outdated Show resolved Hide resolved
utils/eth1.go Outdated Show resolved Hide resolved
- Improve variable names
- Remove unused spans
- Improve variable handling
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry

utils/eth1.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you removed the text-primary style from 0x to me

@D13ce D13ce merged commit 7e539bd into master Sep 5, 2023
3 checks passed
@D13ce D13ce deleted the BIDS-2432/DontColor0xPrefix branch September 5, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants