Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2434) Fixed inclusion distance for missed slots #2521

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

Eisei24
Copy link
Collaborator

@Eisei24 Eisei24 commented Aug 31, 2023

🤖 Generated by Copilot at 43bee01

This pull request enhances the validator attestation history feature by improving the query and calculation logic from the bigtable and the database, and refactoring the validator sync handler. The changes aim to increase performance, accuracy, and code quality.

db/bigtable.go Show resolved Hide resolved
db/db.go Show resolved Hide resolved
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a suggestion to your comment (and one more unrelated to that). ptal.

(I have not reviewed your code completely yet as you might change it based on my comments)

db/bigtable.go Outdated Show resolved Hide resolved
db/bigtable.go Show resolved Hide resolved
db/bigtable.go Show resolved Hide resolved
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments, ptal.

Overall, lgtm :)

db/bigtable.go Show resolved Hide resolved
db/bigtable.go Outdated Show resolved Hide resolved
db/bigtable.go Show resolved Hide resolved
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eisei24 Eisei24 merged commit e122540 into master Sep 5, 2023
3 checks passed
@Eisei24 Eisei24 deleted the BIDS-2434/Attestation_inclusion_distance_wrong branch September 5, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants