-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BIDS-2434) Fixed inclusion distance for missed slots #2521
(BIDS-2434) Fixed inclusion distance for missed slots #2521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a suggestion to your comment (and one more unrelated to that). ptal.
(I have not reviewed your code completely yet as you might change it based on my comments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 minor comments, ptal.
Overall, lgtm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🤖 Generated by Copilot at 43bee01
This pull request enhances the validator attestation history feature by improving the query and calculation logic from the bigtable and the database, and refactoring the validator sync handler. The changes aim to increase performance, accuracy, and code quality.