Skip to content

Commit

Permalink
Merge pull request #2768 from gobitfly/NOBIDS/ImproveENSResolverError…
Browse files Browse the repository at this point in the history
…Handling

Nobids/improve ens resolver error handling
  • Loading branch information
recy21 authored Dec 12, 2023
2 parents 6c3ec6f + 1149d02 commit 2e91e43
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions db/ens.go
Original file line number Diff line number Diff line change
Expand Up @@ -411,9 +411,9 @@ func (bigtable *Bigtable) ImportEnsUpdates(client *ethclient.Client) error {
if name != "" {
err := validateEnsName(client, name, &alreadyChecked, nil)
if err != nil {
if err.Error() == "not a resolver" {
// if resolving the given name results in an address that is not a resolver, we cannot do anything with it and just skip it
logger.Warnf("resolving name [%s] resulted in an address that is not a resolver, skipping it", name)
if err.Error() == "not a resolver" || err.Error() == "no resultion" {
// if resolving the given name results in an address that is not a resolver or does not have any resolution, we cannot do anything with it and just skip it
logger.Warnf("resolving name [%s] resulted in a skippable error [%s], skipping it", name, err.Error())
} else {
return fmt.Errorf("error validating new name [%v]: %w", name, err)
}
Expand Down

0 comments on commit 2e91e43

Please sign in to comment.