(BIDS-2591) Improve return value for dashboard effectiveness (#2631)

* (BIDS-2591) Improve return value for dashboard effectiveness * (BIDS-2591) Changes based on code review
gobitfly · Oct 24, 2023 · 206c355 · 206c355
1 parent ecfeac2
commit 206c355
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/handlers/dashboard.go b/handlers/dashboard.go
@@ -988,7 +988,8 @@ func DashboardDataEffectiveness(w http.ResponseWriter, r *http.Request) {
 	}
 
 	if len(activeValidators) == 0 {
-		http.Error(w, "Invalid query", http.StatusBadRequest)
+		// valid 200 response with empty data
+		w.Write([]byte(`{}`))
 		return
 	}
 

diff --git a/static/js/dashboard.js b/static/js/dashboard.js
@@ -976,6 +976,9 @@ $(document).ready(function () {
         method: "GET",
       }).then((res) => {
         res.json().then((data) => {
+          if (Object.keys(data).length === 0) {
+            return
+          }
           let sum = 0.0
           for (let eff of data) {
             sum += eff