Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/email: fix sanitization of email addresses #9999

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 6, 2024

Details

closes #9996


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner June 6, 2024 03:46
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit a1c2771
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66613116a93b6e000867b653

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit a1c2771
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66613116d5230d000864d24f

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (105a90d) to head (a1c2771).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9999      +/-   ##
==========================================
- Coverage   92.63%   92.63%   -0.01%     
==========================================
  Files         711      711              
  Lines       34823    34822       -1     
==========================================
- Hits        32258    32257       -1     
  Misses       2565     2565              
Flag Coverage Δ
e2e 49.61% <66.66%> (-0.01%) ⬇️
integration 25.50% <33.33%> (+<0.01%) ⬆️
unit 90.10% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-a1c27719d8e5af9d1b6a33f97b9852dfeda5f33d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-a1c27719d8e5af9d1b6a33f97b9852dfeda5f33d-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-a1c27719d8e5af9d1b6a33f97b9852dfeda5f33d

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-a1c27719d8e5af9d1b6a33f97b9852dfeda5f33d-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 5d85802 into main Jun 6, 2024
67 checks passed
@BeryJu BeryJu deleted the stages/email/fix-sanitization branch June 6, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error sending recovery link via Mail von Display Name has "," in it
1 participant