Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: gitlab: better service description #9923

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented May 31, 2024

Details

closes #9922


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@4d62 4d62 requested a review from a team as a code owner May 31, 2024 01:20
Copy link

netlify bot commented May 31, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 30b3ba8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/666e58e3a541520008b480c8
😎 Deploy Preview https://deploy-preview-9923--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 30b3ba8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/666e58e3b37823000845467f
😎 Deploy Preview https://deploy-preview-9923--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (6a79b3a) to head (30b3ba8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9923   +/-   ##
=======================================
  Coverage   92.60%   92.61%           
=======================================
  Files         711      711           
  Lines       34905    34905           
=======================================
+ Hits        32325    32328    +3     
+ Misses       2580     2577    -3     
Flag Coverage Δ
e2e 49.56% <ø> (+0.03%) ⬆️
integration 25.42% <ø> (ø)
unit 90.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4d62
Copy link
Contributor Author

4d62 commented Jun 11, 2024

hey @tanberry i was wondering if you could review this as well. thanks in advance

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@tanberry tanberry merged commit 340c324 into goauthentik:main Jun 18, 2024
60 of 66 checks passed
@4d62 4d62 deleted the 9922-gitlab-description branch June 19, 2024 15:29
kensternberg-authentik added a commit that referenced this pull request Jun 19, 2024
* main:
  website/docs: update 2024.6 release notes with latest changes (#10174)
  core: fix error when raising SkipObject in mapping (#10153)
  website/docs: 2024.6 release notes: add note about group names (#10170)
  website/docs: update 2024.6 release notes with latest changes (#10167)
  core: bump twilio from 9.1.1 to 9.2.0 (#10162)
  web: bump chromedriver from 126.0.1 to 126.0.2 in /tests/wdio (#10161)
  web: bump the wdio group in /tests/wdio with 4 updates (#10160)
  website/integrations: jellyfin: add OIDC configuration (#9538)
  website/docs: Describe where to apply the auto setup env vars (#9863)
  website/integrations: gitlab: better service description (#9923)
  web: fix docker build for non-release versions (#10154)
  root: makefile: add codespell to make-website (#10116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website/integrations: gitlab: better service description
2 participants