stages/identification: don't check source component #9410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PythonCoderAS <[email protected]>
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
BeryJu
reviewed
Apr 25, 2024
Signed-off-by: Jens L. <[email protected]>
BeryJu
changed the title
|
/cherry-pick version-2024.4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9410 +/- ##
===========================================
- Coverage 92.42% 52.12% -40.30%
===========================================
Files 668 668
Lines 32669 32667 -2
===========================================
- Hits 30194 17029 -13165
- Misses 2475 15638 +13163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Do not include the built-in source in this check Signed-off-by: PythonCoderAS <[email protected]> * Update authentik/stages/identification/stage.py Signed-off-by: Jens L. <[email protected]> --------- Signed-off-by: PythonCoderAS <[email protected]> Signed-off-by: Jens L. <[email protected]> Co-authored-by: Jens L <[email protected]>
BeryJu
added a commit
that referenced
this pull request
Apr 25, 2024
… (#9420) stages/identification: don't check source component (#9410) * Do not include the built-in source in this check * Update authentik/stages/identification/stage.py --------- Signed-off-by: PythonCoderAS <[email protected]> Signed-off-by: Jens L. <[email protected]> Co-authored-by: PythonCoderAS <[email protected]> Co-authored-by: Jens L <[email protected]>
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 30, 2024
* main: web: clean up some repetitive types (#9241) core: fix logic for token expiration (#9426) ci: fix ci pipeline (#9427) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9424) web: Add resolved and integrity fields back to package-lock.json (#9419) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9407) stages/identification: don't check source component (#9410) core: bump selenium from 4.19.0 to 4.20.0 (#9411) core: bump black from 24.4.0 to 24.4.1 (#9412) ci: bump golangci/golangci-lint-action from 4 to 5 (#9413) core: bump goauthentik.io/api/v3 from 3.2024023.2 to 3.2024040.1 (#9414) web: bump @sentry/browser from 7.112.1 to 7.112.2 in /web in the sentry group (#9416) sources/oauth: ensure all UI sources return a valid source (#9401) web: markdown: display markdown even when frontmatter is missing (#9404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Closes #9408
The built-in source does not have a component, so attempting to access it throws a NotImplementedError. This causes it to be skipped.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)