Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: add documentation for OIDC setup with Xen Orchestra #9000

Merged
merged 13 commits into from
Mar 27, 2024
Merged

website/integrations: add documentation for OIDC setup with Xen Orchestra #9000

merged 13 commits into from
Mar 27, 2024

Conversation

pgumpoldsberger
Copy link
Contributor

Details

Added documentation for the configuration with Xen Orchestra according to their blog post.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@pgumpoldsberger pgumpoldsberger requested a review from a team as a code owner March 22, 2024 12:06
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 66ad95a
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6601739581a2fc00084cfe33
😎 Deploy Preview https://deploy-preview-9000--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 66ad95a
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/660173958c6ca7000981a3aa
😎 Deploy Preview https://deploy-preview-9000--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tanberry
Copy link
Contributor

Thanks so much @pgumpoldsberger for these integration docs! I have a couple of small nitpicks, and then a suggestion on formatting of the config steps for Xen Orchestra, but overall great this looks great and we look forward to merging it!

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.02%. Comparing base (cef1d2d) to head (66ad95a).
Report is 406 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9000      +/-   ##
==========================================
+ Coverage   46.62%   52.02%   +5.40%     
==========================================
  Files         626      640      +14     
  Lines       30996    31555     +559     
==========================================
+ Hits        14451    16418    +1967     
+ Misses      16545    15137    -1408     
Flag Coverage Δ
e2e 50.49% <ø> (+5.77%) ⬆️
integration 26.09% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and approve this, but would be great if you could do the few suggestions... the re-formatting of the many steps is up to you, but I do think it would make it easier to read.

Thanks again!

website/integrations/services/xen-orchestra/index.md Outdated Show resolved Hide resolved
website/integrations/services/xen-orchestra/index.md Outdated Show resolved Hide resolved
website/integrations/services/xen-orchestra/index.md Outdated Show resolved Hide resolved
website/integrations/services/xen-orchestra/index.md Outdated Show resolved Hide resolved
website/integrations/services/xen-orchestra/index.md Outdated Show resolved Hide resolved
website/integrations/services/xen-orchestra/index.md Outdated Show resolved Hide resolved
website/integrations/services/xen-orchestra/index.md Outdated Show resolved Hide resolved
@pgumpoldsberger
Copy link
Contributor Author

Thank you very much for your feedback. I'm going to implement your suggestions tomorrow 👍

pgumpoldsberger and others added 8 commits March 23, 2024 08:59
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: pgumpoldsberger <[email protected]>
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: pgumpoldsberger <[email protected]>
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: pgumpoldsberger <[email protected]>
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: pgumpoldsberger <[email protected]>
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: pgumpoldsberger <[email protected]>
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: pgumpoldsberger <[email protected]>
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: pgumpoldsberger <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu merged commit f2199f1 into goauthentik:main Mar 27, 2024
59 of 65 checks passed
kensternberg-authentik added a commit that referenced this pull request Mar 29, 2024
* main:
  web: a few minor bugfixes and lintfixes (#9044)
  website/integrations: add documentation for OIDC setup with Xen Orchestra (#9000)
  website: bump @types/react from 18.2.70 to 18.2.72 in /website (#9041)
  core: bump goauthentik.io/api/v3 from 3.2024022.5 to 3.2024022.6 (#9042)
  web: fix markdown rendering bug for alerts (#9037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants