Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/oauth: add initial group sync #6427

Closed
wants to merge 1 commit into from
Closed

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 30, 2023

Details

Add the option to allow OIDC sources to sync groups

  • Only for OIDC at the moment even though other source types may support it
  • Requires inputting the claim for groups which requires a list of group names
    (Some sources like Azure AD return a list of UUIDs from the groups which we'd need additional logic to resolve)

closes #6184


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner July 30, 2023 15:06
@BeryJu BeryJu requested review from rissson and removed request for a team July 30, 2023 15:06
@netlify
Copy link

netlify bot commented Jul 30, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit d9428dc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64c685ecd276e80008e59a2f

@netlify
Copy link

netlify bot commented Jul 30, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 8980bef
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64c67c71dbacde00081b927f
😎 Deploy Preview https://deploy-preview-6427--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 93.34% and no project coverage change.

Comparison is base (2ac7eb6) 92.46% compared to head (d9428dc) 92.46%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6427      +/-   ##
==========================================
- Coverage   92.46%   92.46%   -0.00%     
==========================================
  Files         561      561              
  Lines       27053    27078      +25     
==========================================
+ Hits        25012    25035      +23     
- Misses       2041     2043       +2     
Flag Coverage Δ
e2e 51.58% <93.34%> (+0.03%) ⬆️
integration 26.54% <46.67%> (+0.03%) ⬆️
unit 89.24% <56.67%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
authentik/sources/oauth/api/source.py 82.48% <ø> (ø)
authentik/sources/oauth/tests/test_type_openid.py 100.00% <ø> (ø)
authentik/sources/oauth/views/callback.py 83.53% <91.31%> (+2.58%) ⬆️
authentik/core/models.py 92.71% <100.00%> (ø)
authentik/core/sources/flow_manager.py 94.24% <100.00%> (ø)
authentik/sources/oauth/models.py 100.00% <100.00%> (ø)
authentik/sources/oauth/types/oidc.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the sources/oauth/groups branch from 8980bef to d9428dc Compare July 30, 2023 15:46
@insunaa
Copy link

insunaa commented Sep 7, 2023

Looks like a great feature!
Will it be possible in the future to not just sync the group's name, but also the gid?

@BeryJu BeryJu requested review from a team as code owners November 18, 2023 22:42
@kPKfQKhuz86
Copy link

hey, just bumping this one up.

this is a deal breaker in my case and due to lack of this feature, I can't consider authentik a solution for my case at the moment. hoping this one is implemented soon, as otherwise I find authentik very intuitive to use!

@los93sol
Copy link

Will this be available soon? Really need this for my use case

@BeryJu
Copy link
Member Author

BeryJu commented Aug 7, 2024

superseded by #8771

@BeryJu BeryJu closed this Aug 7, 2024
@BeryJu BeryJu deleted the sources/oauth/groups branch August 7, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "groups" claim for OIDC OAuth Sources
4 participants