sources/ldap: fix duplicate bind when authenticating user directly to…

[BeryJu]

… LDAP source

Details

closes #5920

Ensure we don't double bind to LDAP when authenticating user, add test to prevent regression

Changes

New Features

• Adds feature which does x, y, and z.

Breaking Changes

• Adds breaking change which causes <issue>.

Checklist

• Local tests pass (ak test authentik/)
• The code has been formatted (make lint-fix)

If an API change has been made

• The API schema has been updated (make gen-build)

If changes to the frontend have been made

• The code has been formatted (make web)
• The translation files have been updated (make i18n-extract)

If applicable

• The documentation has been updated
• The documentation has been formatted (make website)

[netlify]

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	31d811f
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/64863d5e01d29c0008cd2ca7

[codecov]

Codecov Report

Patch coverage: 94.74% and project coverage change: +0.18 🎉

Comparison is base (ee33e2a) 92.42% compared to head (31d811f) 92.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5927      +/-   ##
==========================================
+ Coverage   92.42%   92.59%   +0.18%     
==========================================
  Files         549      549              
  Lines       26340    26355      +15     
==========================================
+ Hits        24343    24402      +59     
+ Misses       1997     1953      -44     

Flag	Coverage Δ
e2e	51.94% <21.06%> (+0.84%)	⬆️
integration	26.46% <0.00%> (-0.01%)	⬇️
unit	89.42% <78.95%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
authentik/sources/ldap/models.py	84.62% <75.00%> (+19.45%)	⬆️
authentik/sources/ldap/auth.py	75.56% <100.00%> (+10.34%)	⬆️
authentik/sources/ldap/tests/test_auth.py	100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-fix-double-bind-1686519802-31d811f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-fix-double-bind-1686519802-31d811f-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-fix-double-bind-1686519802-31d811f

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-fix-double-bind-1686519802-31d811f-arm64

Afterwards, run the upgrade commands from the latest release notes.