Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/ldap: make schema optional #5213

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 9, 2023

closes #4590

needs

  • testing
  • some more refactoring to make .server and .connection not properties
  • ideally some better caching of connections too

Signed-off-by: Jens Langhammer <[email protected]>
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch coverage: 80.40% and project coverage change: -0.02 ⚠️

Comparison is base (549e4dc) 92.76% compared to head (a6b5523) 92.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5213      +/-   ##
==========================================
- Coverage   92.76%   92.74%   -0.02%     
==========================================
  Files         506      506              
  Lines       25846    25860      +14     
==========================================
+ Hits        23973    23980       +7     
- Misses       1873     1880       +7     
Flag Coverage Δ
e2e 52.67% <43.14%> (-<0.01%) ⬇️
integration 26.34% <15.69%> (-0.01%) ⬇️
unit 89.54% <60.79%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/root/test_runner.py 100.00% <ø> (ø)
authentik/sources/ldap/password.py 67.93% <20.00%> (+0.31%) ⬆️
authentik/sources/ldap/models.py 85.40% <70.00%> (-4.35%) ⬇️
authentik/blueprints/v1/tasks.py 73.62% <100.00%> (ø)
authentik/sources/ldap/auth.py 76.09% <100.00%> (-0.50%) ⬇️
authentik/sources/ldap/sync/base.py 94.51% <100.00%> (+0.19%) ⬆️
authentik/sources/ldap/sync/groups.py 89.48% <100.00%> (ø)
authentik/sources/ldap/sync/membership.py 94.24% <100.00%> (ø)
authentik/sources/ldap/sync/users.py 92.31% <100.00%> (ø)
authentik/sources/ldap/tests/test_auth.py 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit f1ea206
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64345cf15f03ea000838a265
😎 Deploy Preview https://deploy-preview-5213--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Jens Langhammer <[email protected]>
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-optional-schema-info-1681154422-02edff4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-optional-schema-info-1681154422-02edff4-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-optional-schema-info-1681154422-02edff4

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-optional-schema-info-1681154422-02edff4-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 1ca8feb into main Apr 10, 2023
@BeryJu BeryJu deleted the sources/ldap/optional-schema-info branch April 10, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAPSchemaError - get_info=NONE
1 participant