Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: clarify traefik ingress setup #11938

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

mandusm
Copy link
Contributor

@mandusm mandusm commented Nov 6, 2024

Details

The instructions for adding middelware to a kubernetes cluster is vague and causes confusion. This change will help make it a little more clear that you should use internal service endpoints, not public ingress endpoints.


Checklist

  • [✅ ] Local tests pass (ak test authentik/)
  • [✅ ] The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

The instructions for adding middelware to a kubernetes cluster is vague and causes confusion. This change will help make it a little more clear that you should use internal service endpoints, not public ingress endpoints. 

Signed-off-by: Mandus Momberg <[email protected]>
@mandusm mandusm requested a review from a team as a code owner November 6, 2024 17:31
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 6ab9466
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/672ba7e553bcc60008db5a42
😎 Deploy Preview https://deploy-preview-11938--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 6ab9466
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/672ba7e53896c40008e8f8da
😎 Deploy Preview https://deploy-preview-11938--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rissson rissson changed the title Provide clear instructions on middelware for traefik kubernetes ingress website/docs: Provide clear instructions on middelware for traefik kubernetes ingress Nov 6, 2024
@rissson rissson changed the title website/docs: Provide clear instructions on middelware for traefik kubernetes ingress website/docs: clarify traefik ingress setup Nov 6, 2024
@rissson rissson enabled auto-merge (squash) November 6, 2024 17:41
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (49577fe) to head (6ab9466).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11938      +/-   ##
==========================================
+ Coverage   92.56%   92.64%   +0.07%     
==========================================
  Files         761      761              
  Lines       37813    37813              
==========================================
+ Hits        35002    35032      +30     
+ Misses       2811     2781      -30     
Flag Coverage Δ
e2e 49.21% <ø> (+0.15%) ⬆️
integration 24.91% <ø> (ø)
unit 90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson merged commit dfb4f86 into goauthentik:main Nov 6, 2024
63 checks passed
kensternberg-authentik added a commit that referenced this pull request Nov 12, 2024
* main:
  website/docs: fix slug matching redirect URI causing broken refresh (#11950)
  website/integrations: jellyfin: update plugin catalog location (#11948)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in de (#11942)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#11946)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#11947)
  website/docs: clarify traefik ingress setup (#11938)
  core: bump importlib-metadata from 8.4.0 to 8.5.0 (#11934)
  web: bump API Client version (#11930)
  root: backport version bump `2024.10.1` (#11929)
  website/docs: `2024.10.1` Release Notes (#11926)
  website: bump path-to-regexp from 1.8.0 to 1.9.0 in /website (#11924)
  core: bump sentry-sdk from 2.17.0 to 2.18.0 (#11918)
  website: bump the docusaurus group in /website with 9 updates (#11917)
  core: bump goauthentik.io/api/v3 from 3.2024100.1 to 3.2024100.2 (#11915)
  core, web: update translations (#11914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants