Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove html language tag for pages that are translated #10611

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 24, 2024

Details

closes #10608

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner July 24, 2024 16:02
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 011e80c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66a125900ad3f00008d3ec89

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 011e80c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66a12590d99c4d0008a1386d

@BeryJu
Copy link
Member Author

BeryJu commented Jul 24, 2024

/cherry-pick version-2024.6

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (49a2a3b) to head (011e80c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10611      +/-   ##
==========================================
+ Coverage   92.51%   92.59%   +0.08%     
==========================================
  Files         718      718              
  Lines       35141    35141              
==========================================
+ Hits        32509    32538      +29     
+ Misses       2632     2603      -29     
Flag Coverage Δ
e2e 49.62% <ø> (+0.11%) ⬆️
integration 25.36% <ø> (ø)
unit 90.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 8e4a2b7 into main Jul 24, 2024
69 checks passed
@BeryJu BeryJu deleted the core/remove-skeleton-lang-tag branch July 24, 2024 16:58
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 24, 2024
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-011e80c8bca037646f946073b40a4b122d29b4be
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-011e80c8bca037646f946073b40a4b122d29b4be-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-011e80c8bca037646f946073b40a4b122d29b4be

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-011e80c8bca037646f946073b40a4b122d29b4be-arm64

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added a commit that referenced this pull request Jul 24, 2024
…pick #10611) (#10613)

core: remove html language tag for pages that are translated (#10611)

Signed-off-by: Jens Langhammer <[email protected]>
Co-authored-by: Jens L. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove <html lang="en"> to prevent translate popups
1 participant