Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages: authenticator_endpoint_gdtc #10477

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 12, 2024

Details

Support Chrome Device Trust


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners July 12, 2024 13:04
@BeryJu BeryJu marked this pull request as draft July 12, 2024 13:04
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit d199420
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6717a4e1406b220009b28745

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit d199420
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6717a4e1e51c5b000867bb23

@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 2 times, most recently from a041ead to a938629 Compare July 13, 2024 13:29
@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from a938629 to 78866da Compare July 23, 2024 16:27
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 83.03030% with 28 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (adfa1b1) to head (d199420).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...se/stages/authenticator_endpoint_gdtc/views/dtc.py 44.18% 24 Missing ⚠️
...rprise/stages/authenticator_endpoint_gdtc/stage.py 81.81% 2 Missing ⚠️
authentik/core/api/devices.py 75.00% 1 Missing ⚠️
...prise/stages/authenticator_endpoint_gdtc/models.py 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10477      +/-   ##
==========================================
+ Coverage   92.52%   92.69%   +0.16%     
==========================================
  Files         740      745       +5     
  Lines       36783    36944     +161     
==========================================
+ Hits        34034    34245     +211     
+ Misses       2749     2699      -50     
Flag Coverage Δ
e2e 49.37% <77.57%> (+0.80%) ⬆️
integration 25.04% <79.72%> (+0.11%) ⬆️
unit 90.23% <83.03%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 4 times, most recently from c6ebbd9 to b564f69 Compare August 18, 2024 13:37
Copy link
Contributor

github-actions bot commented Aug 18, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d19942056036931bb87b57b6e41b969e7fea1535
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d19942056036931bb87b57b6e41b969e7fea1535-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d19942056036931bb87b57b6e41b969e7fea1535

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d19942056036931bb87b57b6e41b969e7fea1535-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 2 times, most recently from e2360c7 to 34bc604 Compare September 24, 2024 15:55
@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch 5 times, most recently from cdb7010 to 1e3a27b Compare October 16, 2024 15:24
Copy link

@BeryJu BeryJu marked this pull request as ready for review October 16, 2024 16:20
@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from 1e3a27b to 259e83a Compare October 18, 2024 17:15
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from ade82a0 to bc0573a Compare October 21, 2024 14:18
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu requested a review from a team as a code owner October 21, 2024 15:42
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits and a question... I'm approving now so that I am not the bottleneck. :-)

BeryJu and others added 5 commits October 22, 2024 14:16
Co-authored-by: Tana M Berry <[email protected]>
Signed-off-by: Jens L. <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu force-pushed the stages/authenticator_endpoint_gdtc branch from 478acf2 to d199420 Compare October 22, 2024 13:13
@BeryJu BeryJu merged commit cec3fdb into main Oct 22, 2024
65 of 66 checks passed
@BeryJu BeryJu deleted the stages/authenticator_endpoint_gdtc branch October 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants