Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: add setting to configure primary django hasher #10195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boesr
Copy link
Contributor

@boesr boesr commented Jun 21, 2024

Details

This pull request makes the primary django hasher configurable via the .env file. I would like to switch the internal hash algorithm to Argon2, due to its compatibility with OpenLDAP. There is no breaking change and the parameter is optional. If not set, the standard django hasher hierarchy is used. I couldn't test it with the current main since the ak server commands gets stuck during migration processes (see #9866). It is tested with 2024.04.


Checklist

  • Local tests pass (ak test authentik/) -> no because main is currently broken, tests are failing before changing anything, at least for me
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build) -> no API changes

If changes to the frontend have been made

  • The code has been formatted (make web) -> no frontend changes

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@boesr boesr requested review from a team as code owners June 21, 2024 06:14
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 8ebbadc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66751a2b0ac47b000855bb5e

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 8ebbadc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66751a2b6fa1e00008bd0250
😎 Deploy Preview https://deploy-preview-10195--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rissson
Copy link
Member

rissson commented Jun 21, 2024

I'm curious as to the use case of this. Do you have custom scripts or things that sync that password back to LDAP?

@boesr
Copy link
Contributor Author

boesr commented Jun 21, 2024

I'm curious as to the use case of this. Do you have custom scripts or things that sync that password back to LDAP?

That will be the case since the performance of integrated ldap provider isn't fast / stable enough for our use case (user login to central server systems via sssd). Besides we only need to provide some users via LDAP. I thought about adding a filter to the integrated LDAP provider, but I think OpenLDAP is more stable / faster.

@boesr
Copy link
Contributor Author

boesr commented Oct 1, 2024

@rissson I there a chance of getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants