Skip to content

Commit

Permalink
web: fix bad name target that's breaking build (#10506)
Browse files Browse the repository at this point in the history
* web: fix esbuild issue with style sheets

Getting ESBuild, Lit, and Storybook to all agree on how to read and parse stylesheets is a serious
pain. This fix better identifies the value types (instances) being passed from various sources in
the repo to the three *different* kinds of style processors we're using (the native one, the
polyfill one, and whatever the heck Storybook does internally).

Falling back to using older CSS instantiating techniques one era at a time seems to do the trick.
It's ugly, but in the face of the aggressive styling we use to avoid Flashes of Unstyled Content
(FLoUC), it's the logic with which we're left.

In standard mode, the following warning appears on the console when running a Flow:

```
Autofocus processing was blocked because a document already has a focused element.
```

In compatibility mode, the following **error** appears on the console when running a Flow:

```
crawler-inject.js:1106 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at initDomMutationObservers (crawler-inject.js:1106:18)
    at crawler-inject.js:1114:24
    at Array.forEach (<anonymous>)
    at initDomMutationObservers (crawler-inject.js:1114:10)
    at crawler-inject.js:1549:1
initDomMutationObservers @ crawler-inject.js:1106
(anonymous) @ crawler-inject.js:1114
initDomMutationObservers @ crawler-inject.js:1114
(anonymous) @ crawler-inject.js:1549
```

Despite this error, nothing seems to be broken and flows work as anticipated.

* root: fix migrations missing using db_alias

Signed-off-by: Marc 'risson' Schmitt <[email protected]>

* more

Signed-off-by: Marc 'risson' Schmitt <[email protected]>

* web: have no idea how this snuck through but I should have caught it.

---------

Signed-off-by: Marc 'risson' Schmitt <[email protected]>
Co-authored-by: Marc 'risson' Schmitt <[email protected]>
  • Loading branch information
kensternberg-authentik and rissson authored Jul 15, 2024
1 parent ee58cf0 commit c0063c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion web/src/user/LibraryPage/ak-library-application-search.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,6 @@ export class LibraryPageApplicationSearch extends AKElement {

declare global {
interface HTMLElementTagNameMap {
"ak-library-list-search": LibraryPageApplicationList;
"ak-library-list-search": LibraryPageApplicationSearch;
}
}

0 comments on commit c0063c1

Please sign in to comment.