add entry message wide string support #412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #412 +/- ##
==========================================
+ Coverage 90.61% 90.91% +0.29%
==========================================
Files 47 47
Lines 4307 4326 +19
Branches 572 574 +2
==========================================
+ Hits 3903 3933 +30
+ Misses 278 264 -14
- Partials 126 129 +3 ☔ View full report in Codecov by Sentry. |
|
@rmknan, this pull is the completion of your previous one. Please feel free to provide a review of it, particularly since it is almost entirely derived from your work. I'll leave it open for a week to give you some time to comment before merging it in. |
|
| @@ -887,6 +887,7 @@ stumpless_set_entry_message_str_w( struct stumpless_entry *entry, | |||
| if( !new_message ){ | |||
| return NULL; | |||
| } | |||
| new_message_size--; // leave off the NULL character | |||
There was a problem hiding this comment.
Yes, I am going through the commits. Could you tell me about this line ?
There was a problem hiding this comment.
The wide string conversion functions return a size that includes the NULL terminator, but the entry message_length member shouldn't include the NULL terminator in it. Stumpless currently assumes that this string is NULL-terminated though, and specifically the stumpless_get_entry_message function does when copying out the message to return. If the NULL terminator is left in on this length, the get entry function will try to read an extra byte at the end because it expects a NULL terminator to be there, which is invalid (and causes valgrind errors).
It's a confusing convention, and the next major version (v3.0) will drop the NULL terminators completely for this reason, but for now this line is necessary to keep everything consistent.
Implements
stumpless_set_entry_message_str_wand fixes some wide string functionality as well.This is a continuation of #376, which implemented most of this functionality but had a few problems remaining, and has since gone stale.
This fixes #272, which can be referenced for more information.