Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sinhala and Japanese localizations #408

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

dylmcgold
Copy link
Contributor

This change resolves #283 and #301 by adding Sinhala and Japanese localizations.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (659b497) to head (8ef4b95).

Additional details and impacted files
@@           Coverage Diff           @@
##           latest     #408   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files          46       46           
  Lines        4188     4188           
  Branches      556      556           
=======================================
  Hits         3792     3792           
  Misses        273      273           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for putting together this update with not just one but two new locales! I believe the only fix needed is to add the L10N_NETWORK_CLOSED_ERROR_MESSAGE definition to the si-lk.h header, which is causing the two test build failures.

@dylmcgold
Copy link
Contributor Author

I added the missing header, thanks for reviewing it. I didn't know how to review the issue myself, but now I see the error message with an undeclared header.

@goatshriek goatshriek merged commit f8368cd into goatshriek:latest Feb 27, 2024
55 checks passed
@goatshriek
Copy link
Owner

Thanks once again for putting this together, and for responding quickly to the requested changes! It is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement sinhala (si-LK) localization
2 participants