-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#293) Solved factor config_open_default_target out of wrapper.h #368
Conversation
I am on a different branch but it seems yesterday's commit have been re-committed. Is that fine? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## latest #368 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 43 43
Lines 3658 3658
Branches 474 474
=======================================
Hits 3349 3349
Misses 216 216
Partials 93 93
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together! There are a few minor changes to make, listed below.
Also, be sure to merge in the latest
branch to yours to remove the seemingly duplicate changes from the string formatting change.
Can you elaborate? For this I issue I created a new branch and after the changes I did |
You need to perform a pull before you do another push. Exactly how you do the pull depends on how you have your local repository set up, but it's likely something like: |
The issue has been solved and the test run successfully. Made changes to
stumpless.yml
and deletedprivate/config/wrapper.h
. New header fileopen_default_target.h
created.