Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#361 stumpless_param_to_string format changes #366

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

rmknan
Copy link
Contributor

@rmknan rmknan commented Sep 15, 2023

Have made changes to the files requested in the issue#361. The format for stumpless_param_to_string has been changed and test run successfully.

@rmknan
Copy link
Contributor Author

rmknan commented Sep 15, 2023

#361

@rmknan rmknan changed the title 361 #361 stumpless_param_to_string format changes Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (111796d) 91.55% compared to head (13bffe3) 91.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #366      +/-   ##
==========================================
- Coverage   91.55%   91.55%   -0.01%     
==========================================
  Files          43       43              
  Lines        3660     3658       -2     
  Branches      474      474              
==========================================
- Hits         3351     3349       -2     
  Misses        216      216              
  Partials       93       93              
Files Changed Coverage Δ
src/param.c 97.10% <100.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look great! The only thing that needs to be done is the removal of the old code/comments, which you have currently commented out.

src/param.c Outdated Show resolved Hide resolved
src/param.c Outdated Show resolved Hide resolved
src/param.c Outdated Show resolved Hide resolved
@goatshriek goatshriek merged commit 9fad9a2 into goatshriek:latest Sep 15, 2023
44 checks passed
@goatshriek
Copy link
Owner

Thanks very much for putting this together and working through all of the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants