-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stumpless_element_to_string function #180
Implement stumpless_element_to_string function #180
Conversation
I have created the draft to open what I have done so far for review (early feedback makes for a less painful process ) In case anyone has suggestions on how to improve the PR feel free to let me know. |
Codecov Report
@@ Coverage Diff @@
## latest #180 +/- ##
==========================================
+ Coverage 95.90% 95.91% +0.01%
==========================================
Files 31 31
Lines 2589 2620 +31
==========================================
+ Hits 2483 2513 +30
- Misses 106 107 +1
Continue to review full report at Codecov.
|
Looks like you're on a good path! Right now the only comment I have is to be sure that you free the result of param_to_string after you memcpy it into the new buffer, otherwise it will become a memory leak. |
Thanks for the heads up, will get it sorted and finished the PR in the next few days 👍🏻 |
This should be ready for review, feel free to suggest any other improvements or corrections @goatshriek |
Looks like you're pretty much there, awesome work on putting this together! My apologies for the delay in running the CI actions, I forgot that they must be manually approved now. Just a few things left to clean up: The most difficult issue is that the Microsoft compiler doesn't appear to support the non-compile-time constant size in the array declaration on line 525 of You'll need to add an entry to the The branch covering elements without any params is currently uncovered - adding another test almost identical to the one starting on line 712 of You can ignore the sonarcloud failure - it won't run for "external" pull requests at the moment. |
Thanks for pointing out the issues in such detail, it helped a lot! I believe this is ready for another go |
Looks great! the mac failures look like a false alarm - I will give this one more check in a few hours and merge it in! |
From #146:
Should I open a follow up issue for this? I would be willing to work on it after #177 @goatshriek |
If you're interested, absolutely! There is a detailed walkthrough of making/measuring performance optimizations in There's no need to feel obligated though; I can always write another |
This addresses #146
element.h
stumpless_element_to_string
in element.c