change element to string format (#369)

Changes the format of stumpless_element_to_string to be similar to
that of the logger command line tool:
`name=[param1="value1",param2="value2"]`.

This fixes #367, which can be referenced for more information.

src/element.c

@@ -218,7 +218,7 @@ stumpless_element_to_string( const struct stumpless_element *element ) {
 
     if( param_count != 0 ) {
       // extra param list chars and commas
-      format_len += 6 + param_count - 1;
+      format_len += 4 + param_count ;
     } else {
       // no params, just name
       format_len += 3;
@@ -229,10 +229,10 @@ stumpless_element_to_string( const struct stumpless_element *element ) {
       goto fail;
     }
 
-    memcpy( format + 1, name, name_len );
+    memcpy( format, name, name_len );
 
     // build params list "param_1_to_string,param_2_to_string, ..."
-    size_t pos_offset = name_len + 4;
+    size_t pos_offset = name_len + 2;
     for( size_t i = 0; i < param_count; i++) {
       // replace '\0' with ',' at the end of each string
       memcpy( format + pos_offset, params_format[i], strlen(params_format[i]));
@@ -246,17 +246,14 @@ stumpless_element_to_string( const struct stumpless_element *element ) {
 
     unlock_element( element );
 
-    format[0] = '<';
-    format[name_len + 1] = '>';
-
     if (param_count != 0 ) {
-      // <name>:[param_1_to_string,param_2_to_string,etc.] (with params)
-      format[name_len + 2] = ':';
-      format[name_len + 3] = '[';
+      // name=[param_1_to_string,param_2_to_string,etc.] (with params)
+      format[name_len ] = '=';
+      format[name_len + 1] = '[';
       format[pos_offset] = ']';
     } else {
-      // <name> (no params)
-      // pos_offset is name_len + 4 here
+      // name (no params)
+      // pos_offset is name_len + 2 here
       pos_offset -= 3;
     }
 

test/function/element.cpp

@@ -808,7 +808,7 @@ namespace {
     format = stumpless_element_to_string( element_with_params );
     ASSERT_NOT_NULL( format );
 
-    EXPECT_STREQ( format, "<element-with-params>:[param-1=\"value-1\",param-2=\"value-2\"]" );
+    EXPECT_STREQ( format, "element-with-params=[param-1=\"value-1\",param-2=\"value-2\"]" );
     EXPECT_NO_ERROR;
 
     free( ( void * ) format );
@@ -820,7 +820,7 @@ namespace {
     format = stumpless_element_to_string( basic_element );
     ASSERT_NOT_NULL( format );
 
-    EXPECT_STREQ( format, "<basic-element>" );
+    EXPECT_STREQ( format, "basic-element" );
     EXPECT_NO_ERROR;
 
     free( ( void * ) format );