Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontier URL and fix news handling. #96

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

rankynbass
Copy link
Contributor

@rankynbass rankynbass commented Nov 18, 2023

When commit 050c3c4 was added to XL, it broke XL.Core.

  1. The frontier URL endpoint was changed, and the XL.Common launcher now requires a frontier URL. I made a quick and dirty hack to hardcode the lastest value of "https://launcher.finalfantasyxiv.com/v650/index.html?rc_lang={0}&time={1}". Considering the current default value of "https://launcher.finalfantasyxiv.com/v620/index.html?rc_lang={0}&time={1}" still works most of the time, this should work until 7.0.
  2. Headline handling was changed from a single function to four. I adjusted the NewsFrame class to account for these changes.

Also update submodule to lastest master.
@rankynbass rankynbass marked this pull request as ready for review November 18, 2023 22:59
@marzent marzent merged commit dfbc483 into goatcorp:main Nov 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants