Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor adjustments before next public release announcement #50

Merged
merged 3 commits into from
Jun 17, 2023
Merged

Minor adjustments before next public release announcement #50

merged 3 commits into from
Jun 17, 2023

Conversation

reiichi001
Copy link
Contributor

  • Fixes a troubleshooting pack / xllog typo
  • Removes duplicate troubleshooting pack generator button
  • Updates some wording for Settings/GameTab

@reiichi001
Set correct github origin for official build check
9402b57
@reiichi001
Remove troubleshooting pack button from AboutTab
e4be63a 
Since this has been added to the Troubleshooting tab, we should direct users there instead. This also means we don't have to worry about two competing buttons that could eventually call the method differently.
@reiichi001
Adjust GameTab wording
22665ab 
- Make the "additional arguments" more explicit that this is for FFXIV's game arguments, not xlcore.
- Explicitly state UID Cache is experimental, like in WPF. Also add some additional wording and warnings.
rankynbass
rankynbass approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@rankynbass rankynbass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I know my approval doesn't offically mean anything, but it builds just fine and launches, not that that should be a surprise. Pointing to the right github repo is probably the most important bit here.

@Blooym Blooym merged commit c57eb5b into goatcorp:main Jun 17, 2023
rankynbass added a commit to rankynbass/XIVLauncher.Core that referenced this pull request Jul 15, 2023
@rankynbass
Merge back to main @ 1.0.4
68b450c 
Squashed commit of the following:

commit 9f0f799
Merge: efa796f 8d2c202
Author: marzent <[email protected]>
Date:   Sat Jun 24 17:35:35 2023 +0300

    Merge pull request goatcorp#57 from goatcorp/dalamud-log-path

    Adjust dalamud log path

commit 8d2c202
Author: Marc-Aurel Zent <[email protected]>
Date:   Sat Jun 24 11:24:25 2023 +0300

    adjust dalamud log path

commit efa796f
Merge: 9d4646a 1af4346
Author: marzent <[email protected]>
Date:   Fri Jun 23 11:49:57 2023 +0300

    Merge pull request goatcorp#55 from rankynbass/fix-empty-toolfolder-and-custom-wine

    [Fix] Create dxvk and wine folders no matter what

commit 1af4346
Author: Rankyn Bass <[email protected]>
Date:   Sun Jun 18 18:07:39 2023 -0700

    Create dxvk and wine folders no matter what

commit 9d4646a
Merge: a581ea9 70c0967
Author: Harmony <[email protected]>
Date:   Mon Jun 19 02:03:34 2023 +0100

    Merge pull request goatcorp#54 from reiichi001/dotnet_publish

    Fix Release GHA

commit 70c0967
Author: Robert Baker <[email protected]>
Date:   Sun Jun 18 17:04:58 2023 -0700

    Fix Release GHA

    I don't know if I hate tabs or spaces more, but everyone can agree that mixing them is the worst.

commit c73fa2d
Merge: 57e37a7 a581ea9
Author: Robert Baker <[email protected]>
Date:   Sun Jun 18 17:03:23 2023 -0700

    Merge remote-tracking branch 'origin/main' into dotnet_publish

commit a581ea9
Merge: bfa1ca6 49309be
Author: R <[email protected]>
Date:   Sun Jun 18 16:59:49 2023 -0700

    Merge pull request goatcorp#53 from rankynbass/fix-win7-code

    Fix win7 code being in wrong place

commit 49309be
Author: Rankyn Bass <[email protected]>
Date:   Sun Jun 18 16:56:45 2023 -0700

    Fix win7 code being in wrong place

commit bfa1ca6
Merge: d7b1d87 fd9a17c
Author: marzent <[email protected]>
Date:   Sun Jun 18 07:04:11 2023 +0200

    Merge pull request goatcorp#52 from rankynbass/add-win7-option

    Add win7 option

commit fd9a17c
Author: Rankyn Bass <[email protected]>
Date:   Sat Jun 17 22:00:56 2023 -0700

    Fix the wording to show Win7 as recommended default

commit c68253c
Author: Rankyn Bass <[email protected]>
Date:   Sat Jun 17 21:52:09 2023 -0700

    Add checkbox to set windows version to 7

commit d7b1d87
Merge: c57eb5b 57e37a7
Author: Harmony <[email protected]>
Date:   Sat Jun 17 23:15:59 2023 +0100

    Merge pull request goatcorp#51 from reiichi001/dotnet_publish

    CI Updates - switch to dotnet publish and restrict releases

commit 57e37a7
Author: Robert Baker <[email protected]>
Date:   Sat Jun 17 14:59:16 2023 -0700

    Restrict release workflow to goatcorp

commit 5ca4cb0
Author: Robert Baker <[email protected]>
Date:   Sat Jun 17 14:59:01 2023 -0700

    Switch GHA release workflow to dotnet publish

commit 72cf794
Author: Robert Baker <[email protected]>
Date:   Sat Jun 17 14:58:52 2023 -0700

    Switch GHA build workflow to dotnet publish

commit c57eb5b
Merge: 20178de 22665ab
Author: Harmony <[email protected]>
Date:   Sat Jun 17 22:20:08 2023 +0100

    Merge pull request goatcorp#50 from reiichi001/minor_fixes_1.0.4

    Minor adjustments before next public release announcement

commit 22665ab
Author: Robert Baker <[email protected]>
Date:   Sat Jun 17 12:42:37 2023 -0700

    Adjust GameTab wording

    - Make the "additional arguments" more explicit that this is for FFXIV's game arguments, not xlcore.
    - Explicitly state UID Cache is experimental, like in WPF. Also add some additional wording and warnings.

commit e4be63a
Author: Robert Baker <[email protected]>
Date:   Sat Jun 17 12:38:06 2023 -0700

    Remove troubleshooting pack button from AboutTab

    Since this has been added to the Troubleshooting tab, we should direct users there instead. This also means we don't have to worry about two competing buttons that could eventually call the method differently.

commit 9402b57
Author: Robert Baker <[email protected]>
Date:   Sat Jun 17 12:35:33 2023 -0700

    Set correct github origin for official build check

commit 20178de
Merge: f9a40ed 6fec82a
Author: goat <[email protected]>
Date:   Sat Jun 17 17:09:15 2023 +0200

    Merge pull request goatcorp#47 from goatcorp/fix-xml-header

commit 6fec82a
Author: Harmony <[email protected]>
Date:   Sat Jun 17 16:06:32 2023 +0100

    ci: add xml header back for appstream file

commit f9a40ed
Merge: e0ac7ad e6df84d
Author: goat <[email protected]>
Date:   Sat Jun 17 16:28:52 2023 +0200

    Merge pull request goatcorp#46 from goatcorp/bump-ver

commit e6df84d
Author: Harmony <[email protected]>
Date:   Sat Jun 17 15:28:26 2023 +0100

    Bump version

commit e0ac7ad
Merge: 3705918 7e8bee3
Author: goat <[email protected]>
Date:   Sat Jun 17 16:25:19 2023 +0200

    Merge pull request #27 from Blooym/update-appstream-file

commit 3705918
Merge: 8ae4e95 20f3495
Author: goat <[email protected]>
Date:   Sat Jun 17 16:23:30 2023 +0200

    Merge pull request goatcorp#45 from Blooym/submodule-update

commit 20f3495
Author: Harmony <[email protected]>
Date:   Sat Jun 17 13:54:08 2023 +0100

    chore: update submodule

commit 7e8bee3
Author: Harmony <[email protected]>
Date:   Sat Jun 17 13:48:30 2023 +0100

    ci: Improve all flows

commit 8ae4e95
Merge: 1ee7ad7 6f9dc1a
Author: Harmony <[email protected]>
Date:   Fri Jun 16 18:37:22 2023 +0100

    Merge pull request goatcorp#32 from rankynbass/add-troubleshoot-options

    Add troubleshoot options

commit 1ee7ad7
Merge: 35df567 ba63017
Author: Harmony <[email protected]>
Date:   Fri Jun 16 17:32:23 2023 +0100

    Merge pull request #28 from Blooym/launch-without-3pp

    Launch without 3rd-party plugins option

commit 35df567
Merge: 3a57e99 dea7663
Author: Harmony <[email protected]>
Date:   Fri Jun 16 17:31:55 2023 +0100

    Merge pull request goatcorp#40 from Blooym/app-cleanup

    Subtle UI/UX Adjustments

commit 3a57e99
Merge: e249a2f eefa42a
Author: Harmony <[email protected]>
Date:   Sat Jun 10 12:34:39 2023 +0100

    Merge pull request goatcorp#41 from rankynbass/bugfix-IsIgnoringSteam

    Fix: IsIgnoringSteam no longer opens Fts Error page on Steam Deck

commit e249a2f
Merge: c2e02fd efa6086
Author: Harmony <[email protected]>
Date:   Wed Jun 7 05:26:14 2023 +0100

    Merge pull request goatcorp#42 from reiichi001/patch-2

    Update README.md

commit efa6086
Author: R <[email protected]>
Date:   Thu May 11 13:12:00 2023 -0700

    Update README.md

    Add PPA link. Also alphabetize the entries

commit 6f9dc1a
Author: Rankyn Bass <[email protected]>
Date:   Fri May 5 21:52:35 2023 -0700

    Cleaned up FtsPage, undid About Tab change

commit eefa42a
Author: Rankyn Bass <[email protected]>
Date:   Fri May 5 21:39:53 2023 -0700

    Clean up a few more things

commit e88678e
Author: Rankyn Bass <[email protected]>
Date:   Tue May 2 19:52:04 2023 -0700

    Get rid of some whitespace for cleaner merges

commit f4de107
Author: Rankyn Bass <[email protected]>
Date:   Mon May 1 20:30:24 2023 -0700

    Move Ignore Steam option back to Game tab

commit 2c8fd67
Author: Rankyn Bass <[email protected]>
Date:   Mon May 1 20:24:28 2023 -0700

    Remove steam appid fix: moved to its own patch

commit c2b35fd
Author: Rankyn Bass <[email protected]>
Date:   Mon Apr 17 22:35:34 2023 -0700

    Get rid of dev lines, reorder code, add comments

commit ca0a9d2
Author: Rankyn Bass <[email protected]>
Date:   Mon Apr 17 18:29:19 2023 -0700

    Add some more troubleshooting options
    * Add hacks for LD_PRELOAD and XMODIFIERS=@im=null
    * Moved those & ignore steam to troubleshooting tab
    * Improved Additional Arguments (Steam style with env vars, %command%)

commit 6a46cf4
Author: Rankyn Bass <[email protected]>
Date:   Thu Apr 13 17:28:04 2023 -0700

    Fix: IsIgnoringSteam no longer opens Fts Error page on Steam Deck

commit dea7663
Author: BitsOfAByte <[email protected]>
Date:   Mon Apr 3 14:12:44 2023 +0100

    Home page cleanup

commit 3e64ed9
Author: BitsOfAByte <[email protected]>
Date:   Mon Apr 3 13:17:51 2023 +0100

    Whitespace fixes

commit 2344389
Author: BitsOfAByte <[email protected]>
Date:   Mon Apr 3 13:16:02 2023 +0100

    Minor app UI cleanup

commit e1812f6
Author: Harmony <[email protected]>
Date:   Sat Mar 25 14:45:31 2023 +0000

    Cleanup and fix nuget dep generation

commit ba63017
Author: BitsOfAByte <[email protected]>
Date:   Sun Jan 15 22:18:31 2023 +0000

    feat: launch without 3rd-party plugins option

commit 94e041e
Author: Harmony <[email protected]>
Date:   Sat Jan 14 20:58:34 2023 +0000

    Update build artifact generation for builds

commit 281bb51
Author: Harmony <[email protected]>
Date:   Sat Jan 14 20:57:57 2023 +0000

    Add artifacts to tag releases

commit 4f75cac
Author: Harmony <[email protected]>
Date:   Sat Jan 14 19:38:56 2023 +0000

    Update script

commit 0ffb96f
Author: Harmony <[email protected]>
Date:   Sat Jan 14 19:38:31 2023 +0000

    Update workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rankynbass rankynbass rankynbass approved these changes

@Blooym Blooym Blooym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reiichi001 @Blooym @rankynbass