fix: Corrected log paths in PackGenerator to include dalamud logs #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs are all now in the logs/ folder, but the pack generator code didn't get corrected. As a result, tspacks didn't include dalamud logs. This PR fixes those paths so all the logs will be properly included.
As an aside, I'm not sure where patcher.log and aria.log actually end up, or if they even get generated for xlcore. They don't end up in ~/.xlcore or ~/.xlcore/logs. I've set them to ~/.xlcore/logs as well.