fix: Use red Ban button for invalid settings #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rankynbass
referenced
this pull request
in rankynbass/XIVLauncher.Core
Dec 11, 2022
* removed a few settings from wine tab * Added dxvk settings to launcher.ini * Updated CreateCompatToolsInstance to work with new dxvkSettings * Requires PR#1205 from FFXIVQuickLauncher * Suggest doing PR#13, #15 on xlcore, for better look and feel.
rankynbass
referenced
this pull request
in rankynbass/XIVLauncher.Core
Jan 5, 2023
* removed a few settings from wine tab * Added dxvk settings to launcher.ini * Updated CreateCompatToolsInstance to work with new dxvkSettings * Requires PR#1205 from FFXIVQuickLauncher * Suggest doing PR#13, #15 on xlcore, for better look and feel.
goaaats
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When settings are invalid, instead of just making the check button un-clickable, replace it with a red ban button (circle with a slash through it). This gives better feedback to the user that something is wrong. This is particularly useful when the error is on another tab, in which case the user might just think the program is broken.