Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and minor features added for XL.Core #13

Merged
merged 6 commits into from
Jan 14, 2023
Merged

Fixes and minor features added for XL.Core #13

merged 6 commits into from
Jan 14, 2023

Conversation

rankynbass
Copy link
Contributor

@rankynbass rankynbass commented Dec 7, 2022 •
edited
Loading

Added Features:

  • Tweaked the UI for pulldown menus on enums. There was an unused Description variable. I just added some logic to display it in the pulldown. If there is no description, or if it's "dummy" (dalamud injection), it doesn't display anything extra.
  • Tweaked the numerics input. The Name text now appears above, instead of on the right side. This is more consistent with the rest of the UI elements.
  • Added a working Cancel button to the One Time Password input. Clicking on it sends you back to the main page.

Cancel Button:
feature-otp-cancel-button

Name above on Numerics Input:
tweak-numerics

Description added to pulldowns:
tweak-pulldowns

@rankynbass
fix: create wine prefix with custom wine.
6ee82c8 
* function failed to initialize dxvk if no wine prefix existed
  and custom wine selected, resulting in crash.
* Also updated error messages to include errors for no wine64
  found at location and path not existing.
@rankynbass
feat: Add Cancel button to OTP
299cad5
@rankynbass
feat: add description to pull-down menus (enums)
1c41ca8 
* Also moved name above numerics, instead of to the right.
  This is more consistant with the other inputs.
@rankynbass
Use Path.Combine for safety.
bfd4eca
@rankynbass
Revert "Use Path.Combine for safety."
410dd80 
This reverts commit bfd4eca.
@rankynbass
Revert "fix: create wine prefix with custom wine."
7c4a475 
This reverts commit 6ee82c8.
@rankynbass
Copy link
Contributor Author

Removed the wine prefix stuff as being out of scope. This is just a UI tweak patch now.

@rankynbass rankynbass mentioned this pull request Dec 11, 2022
Closed
@goaaats goaaats merged commit 86f6cd0 into goatcorp:main Jan 14, 2023
@rankynbass rankynbass deleted the xlcore-tweaks branch April 13, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goaaats goaaats goaaats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rankynbass @goaaats