Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide line marker info for advised methods/properties #1

Closed
3 tasks done
lisachenko opened this issue May 28, 2015 · 6 comments
Closed
3 tasks done

Provide line marker info for advised methods/properties #1

lisachenko opened this issue May 28, 2015 · 6 comments
Labels
Milestone

Comments

@lisachenko
Copy link
Member

Most wanted feature for framework plugin should be analysis of pointcuts and joinpoints in runtime and providing a markers with ability to go to/from advised class/advisor. Something like icon on the gutter, but for advices and matching joinpoints:

inheritance-php

List of issues to resolve before this one:

@lisachenko
Copy link
Member Author

Examples from IDEA and Spring aspects:

Navigation from advices to the advised joinpoints:
spring-aspect-marker

Navigation from joinpoints to the advices:
spring-class-marker

@lisachenko
Copy link
Member Author

Done, but now navigation only works from advised elements to the advices. Resolving elements for advices is too expensive for now. Need to think about this more.

@lisachenko
Copy link
Member Author

Here is a gif with working navigation :)

advise-navigation

@TheCelavi
Copy link

Shoud this feature display ALL advised methods/properties?

I have 4 classes with 6 advised method per each class (24 in total). Only 6 from first class are displayed in the list.

@lisachenko
Copy link
Member Author

@TheCelavi your question is related more to the #5. And previously everything was working, so yes. There should be 24 methods to navigate to from the one single aspect advice.
But, still have question: are your classes in the same directory or not? (Maybe you use some of them from vendor classes?)

@TheCelavi
Copy link

All 4 classes are in same directory, non of those classes are in vendor directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants