Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis Windows build support #414

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Add travis Windows build support #414

merged 1 commit into from
Feb 14, 2019

Conversation

icanhazstring
Copy link
Member

Trying to add windows build for php.
This will replace appveyor if possible

@lisachenko
Copy link
Member

Hi, thx! Let's target 2.x branch for the PR

@lisachenko lisachenko changed the base branch from master to 2.x February 14, 2019 13:11
@lisachenko lisachenko changed the base branch from 2.x to master February 14, 2019 13:11
@lisachenko
Copy link
Member

The language 'php' is currently unsupported on the Windows Build Environment.
Let us know if you'd like to see it: https://travis-ci.community/c/environments/windows. Thanks for understanding!

@icanhazstring
Copy link
Member Author

The language 'php' is currently unsupported on the Windows Build Environment.
Let us know if you'd like to see it: https://travis-ci.community/c/environments/windows. Thanks for understanding!

Yep. Tryping to find a workaround. Maybe it works for at least current php version. Lets see ;)

@lisachenko
Copy link
Member

Please read https://travis-ci.community/t/where-to-contribute-php-support-for-windows/304/3 some info may be useful

@icanhazstring
Copy link
Member Author

Almost there ;)

@lisachenko
Copy link
Member

Congratulations! 🎆

@icanhazstring
Copy link
Member Author

icanhazstring commented Feb 14, 2019

Congratulations! 🎆

Thanks @lisachenko. There is a slight bug here comparing two strings of generated classes.
Maybe this should be checked in another issue/pr. This has something to do with heredoc on windows. (Might be using windows lineendings)

Can possibly be solved with:
PHP-CS-Fixer/PHP-CS-Fixer@d60e963
https://github.com/GeckoPackages/GeckoPHPUnit/pull/18/files


Edit:
Or maybe this should be fixed here.
Since this will break the build ;)

language: sh
os: windows
before_script:
- choco install php --version 7.2.15 --package-parameters='"/InstallDir:C:\php"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to fetch latest available version of 7.2.x here to download it automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puh don't know if that is possible. I will look into it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this issue:

chocolatey/choco#800

@lisachenko
Copy link
Member

Could you please also target 2.x branch? I want to make 2.x working with Windows build too. And perform merge of 2.x into master later.

@lisachenko lisachenko changed the title WIP Add travis windows build Add travis Windows build support Feb 14, 2019
- name: "PHP: 7.2"
language: sh
os: windows
before_script:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if Travis supports color output )

-  SET ANSICON=121x90 (121x90)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see xD

Copy link
Member Author

@icanhazstring icanhazstring Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly not

@icanhazstring icanhazstring changed the base branch from master to 2.x February 14, 2019 15:55
@icanhazstring
Copy link
Member Author

Could you please also target 2.x branch? I want to make 2.x working with Windows build too. And perform merge of 2.x into master later.

@lisachenko rebased from 2.x

@icanhazstring
Copy link
Member Author

Oh hello. The build works now :D

@icanhazstring
Copy link
Member Author

@lisachenko I will squash commits into a single one. So we can merge this one a tackle #402 issue on windows.

@lisachenko
Copy link
Member

All green! Perfect! 👍

@lisachenko lisachenko merged commit 6f81f06 into goaop:2.x Feb 14, 2019
@icanhazstring icanhazstring deleted the feature/travis-windows-build branch February 14, 2019 16:21
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants