Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3490929: Add a redirect for profile canonical links to user information page #4221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

navneet0693
Copy link
Collaborator

Problem (for internal)

In https://www.drupal.org/project/social/issues/3044337, we added a user experience in which we added a redirect from canonical user entity urls (/user/uid) to user stream page.

Even though we will hardly see the profile canonical urls being presented to end user on the platform, but we have certain edge cases where these URL may appear. For example, the profile entities are indexed with the profile canonical urls in social_user and social_all indexes. They may appear in searches if someone decides to add some custom search pages. Also, a user can simply visit /profile/profile-id which may appear broken as it is not intended user information page.

Solution (for internal)

Since, we do not want to alter the canonical profile urls as it may break some default behaviors of profile entity, so we are adding a redirect to user stream page or to the page which set by site manager or admin as default user profile landing page at /admin/config/opensocial/user.

Release notes (to customers)

Clicking on the user profile result in search autocomplete results will now land you on user information page.

Issue tracker

https://www.drupal.org/project/social/issues/3490929

Theme issue tracker

N.A

How to test

  • Using latest version of Open Social
  • Go to /profile/profile-id. You can use user ID in this url.
  • You will land on a page which may appear broken
  • Checkout to this branch
  • Clear Cache.
  • Go to /profile/profile-id
  • You should end up on default user profile page

Change Record

N.A

Translations

N.A

@navneet0693 navneet0693 added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: medium team: support labels Dec 1, 2024
@navneet0693 navneet0693 added this to the 12.3.10 milestone Dec 1, 2024
@navneet0693 navneet0693 force-pushed the issue/3490929-profile-canonical-redirect branch from f2e947b to ff97a7a Compare December 2, 2024 04:08
@navneet0693 navneet0693 added status: needs work This pull request needs more work before it's ready for review and removed status: needs review This pull request is waiting for a requested review labels Dec 2, 2024
…formation page

In https://www.drupal.org/project/social/issues/3044337, we added a user experience in which we added a redirect from canonical user entity urls (/user/uid) to user stream page.

Even though we will hardly see the profile canonical urls being presented to end user on the platform, but we have certain edge cases where these URL may appear. For example, the profile entities are indexed with the profile canonical urls in social_user and social_all indexes. They may appear in searches if someone decides to add some custom search pages. Also, a user can simply visit /profile/profile-id which may appear broken as it is not intended user information page.

Since, we do not want to alter the canonical profile urls as it may break some default behaviors of profile entity, so we are adding a redirect to user stream page or to the page which set by site manager or admin as default user profile landing page at /admin/config/opensocial/user.
@navneet0693 navneet0693 force-pushed the issue/3490929-profile-canonical-redirect branch from ff97a7a to 5b8db02 Compare December 3, 2024 04:14
@navneet0693 navneet0693 added status: needs review This pull request is waiting for a requested review and removed status: needs work This pull request needs more work before it's ready for review labels Dec 3, 2024
@navneet0693 navneet0693 modified the milestones: 12.3.10, 12.4.8 Dec 3, 2024
@robertragas robertragas modified the milestones: 12.4.8, 12.4.9 Dec 3, 2024
@open-social-tugboat
Copy link

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: support type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

3 participants