sqlite3 - database is locked error message

[compressed]

When running gogs with sqlite3, the method:

func (session *Session) Iterate(bean interface{}, fun IterFunc)

around line 901 in session.go is returning an error that the database is locked.

This method seems to initiate the UpdateHookTask method (line 232 in models/webhook.go for gogs), which subsequently fails and the task is not updated. The database is not locked after the command fails.

Steps to replicate:

1. Use sqlite as backend for gogs
2. Add webhook to repo
3. Commit to repo
4. Look in log for database locked message.

Trying with MySQL, I'm not able to replicate the problem.

[compressed]

Actually it seems this may be the source of the error: mattn/go-sqlite3#50

Let me know if you have any other ideas. I can just move away from sqlite.

[compressed]

Ah... according to mattn/go-sqlite3#39 opening the db like so may fix this:

 db, err := sql.Open("sqlite3", "file:locked.sqlite?cache=shared&mode=rwc")

[lunny]

OK. Great issue! I will add this to troubleshooting.

[lunny]

@unknwon, I think the gogs sqlite3 build should use the new connection string.

[unknwon]

locked.sqlite is the file name?

[compressed]

One update on this - I tried yesterday to use the new connection string in gogs (modified here https://github.com/gogits/gogs/blob/master/models/models.go#L80), but it didn't seem to help resolve the problem unfortunately... Was testing with sqlite 3.8.6 on OSX.

[compressed]

Yep locked.sqlite would be gogs.db in our case.

[unknwon]

Let me test on my Mac and SQLite3, are you pushing through HTTP or SSH?

[compressed]

I was pushing through HTTP.

[unknwon]

Is that because you use go deliveryHook?

[compressed]

Ah nope - HTTP push just works better with the security infrastructure I have in place.

[unknwon]

OK, I'll test later.

[unknwon]

This bug is confirmed.

[unknwon]

@compressed I change the way to update hook tasks, which now works fine in SQLite3. But, this is still a bug in ORM level.

[mattn]

Could you please try latest?

[lunny]

Is this still a problem?

[unknwon]

@lunny SQLite3 cannot do session and global x at same time for same table, different tables are OK. Based on my experiences.

[lunny]

Please follow mattn/go-sqlite3#39 comments to resolve the problem.