-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go): Update to Go 1.18 & remove Kaniko Dependencies #20
Conversation
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 3 3
Lines 291 291
=======================================
Hits 272 272
Misses 13 13
Partials 6 6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration test is failing :(
@wass3r I'll take a look at this today. Was out sick last week. |
This updates the plugin to use Go 1.18 and in doing so enables the use of runtime info analysis for the Git commit information. This removes the dependency on Kaniko for version information and by extension the types package as well.