Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): Update to Go 1.18 & remove Kaniko Dependencies #20

Merged
merged 8 commits into from
Apr 11, 2022

Conversation

GregoryDosh
Copy link
Contributor

This updates the plugin to use Go 1.18 and in doing so enables the use of runtime info analysis for the Git commit information. This removes the dependency on Kaniko for version information and by extension the types package as well.

@GregoryDosh GregoryDosh requested a review from a team as a code owner March 25, 2022 15:59
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #20 (78daae7) into main (a28eccc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files           3        3           
  Lines         291      291           
=======================================
  Hits          272      272           
  Misses         13       13           
  Partials        6        6           
Impacted Files Coverage Δ
internal/scp/scp.go 92.10% <100.00%> (ø)
internal/ssh/ssh.go 91.66% <100.00%> (ø)

@GregoryDosh GregoryDosh requested a review from a team March 25, 2022 16:17
plyr4
plyr4 previously approved these changes Mar 29, 2022
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test is failing :(

@GregoryDosh
Copy link
Contributor Author

@wass3r I'll take a look at this today. Was out sick last week.

@GregoryDosh
Copy link
Contributor Author

@plyr4 & @wass3r Thanks for the review, updated GHA to use Go 1.18 for the integration tests now too. Just need another set of eyes please :-)

@GregoryDosh GregoryDosh merged commit 44c7553 into main Apr 11, 2022
@GregoryDosh GregoryDosh deleted the feat/go-1.18-buildinfo branch April 11, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants