Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: annotate versions for renovate management #12

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

GregoryDosh
Copy link
Contributor

@GregoryDosh GregoryDosh commented Feb 17, 2022

This aims to extend Renovate so that it can manage the binary dependencies from the Makefile along with pinning a particular version of the alpine image in the Dockerfiles so that it can be managed as well.

Here is a link to a Regex101 share of the regex group matching with the makefile. Note that the regex101 has converted all \\s into \s just because of the JSON interpolation stuffs.
https://regex101.com/r/hHiMta/1

This followed from the example in the Whitesource documentation that @wass3r pointed out in a previous PR: https://docs.renovatebot.com/modules/datasource/#repology-datasource

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #12 (ce164b8) into main (91b9234) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files           3        3           
  Lines         288      288           
=======================================
  Hits          269      269           
  Misses         13       13           
  Partials        6        6           

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick work. Anxious to see that in action.

@GregoryDosh GregoryDosh requested a review from kaymckay March 1, 2022 15:03
Copy link
Contributor

@kaymckay kaymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GregoryDosh GregoryDosh merged commit fa684b5 into main Mar 1, 2022
@GregoryDosh GregoryDosh deleted the feat/renovate-version-management branch March 1, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants