Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup golangci output in github actions #99

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

kaymckay
Copy link
Contributor

@kaymckay kaymckay commented Feb 7, 2022

fix golangci warnings to clean up PRs

@kaymckay kaymckay requested review from a team February 7, 2022 20:36
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #99 (8a586e3) into master (3716ac8) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   59.93%   60.06%   +0.13%     
==========================================
  Files           9        9              
  Lines         614      616       +2     
==========================================
+ Hits          368      370       +2     
  Misses        244      244              
  Partials        2        2              
Impacted Files Coverage Δ
cmd/vela-kubernetes/config.go 100.00% <ø> (ø)
cmd/vela-kubernetes/kubectl.go 89.47% <100.00%> (+0.58%) ⬆️

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaymckay kaymckay merged commit f546acc into master Feb 16, 2022
@kaymckay kaymckay deleted the golangci-cleanup branch February 16, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants