Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new version pkg #49

Merged
merged 4 commits into from
Oct 23, 2020
Merged

feat: use new version pkg #49

merged 4 commits into from
Oct 23, 2020

Conversation

jbrockopp
Copy link
Contributor

Dependent on go-vela/types#112

Updating to the new go-vela/types/version package to improve the information provided surrounding the application.

When I run make run locally, here is the output:

{
  "canonical": "v0.2.0",
  "major": 0,
  "minor": 2,
  "patch": 0,
  "metadata": {
    "architecture": "amd64",
    "build_date": "2020-10-20T12:24:09Z",
    "compiler": "gc",
    "git_commit": "10d003e4e85154a5816539f816f028c520bd193b",
    "go_version": "go1.15.2",
    "operating_system": "linux"
  }
}
<more logs>

NOTE: This also updates the GitHub Actions pipelines to use our make commands for building the binary.

@jbrockopp jbrockopp added the feature Indicates a new feature label Oct 20, 2020
@jbrockopp jbrockopp self-assigned this Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #49 into master will decrease coverage by 0.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   46.35%   45.75%   -0.60%     
==========================================
  Files           9        9              
  Lines         384      389       +5     
==========================================
  Hits          178      178              
- Misses        204      209       +5     
  Partials        2        2              
Impacted Files Coverage Δ
cmd/vela-kubernetes/main.go 0.00% <0.00%> (ø)

@jbrockopp jbrockopp marked this pull request as ready for review October 20, 2020 20:32
@jbrockopp jbrockopp requested a review from a team as a code owner October 20, 2020 20:32
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit e5e3fa8 into master Oct 23, 2020
@kneal kneal deleted the feat/version branch October 23, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants