Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert true to always pull policy #48

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

jbrockopp
Copy link
Contributor

This PR updates the existing docs for the pull attribute to match the newly created pull policies.

To accomplish this, I performed a find and replace for converting

pull: true

to

pull: always

Also found in this PR is updating the tag for the Docker image we reference to latest 👍

@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label Sep 30, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner September 30, 2020 17:48
@jbrockopp jbrockopp self-assigned this Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #48 into master will decrease coverage by 2.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   49.14%   46.35%   -2.80%     
==========================================
  Files           9        9              
  Lines         409      384      -25     
==========================================
- Hits          201      178      -23     
+ Misses        206      204       -2     
  Partials        2        2              
Impacted Files Coverage Δ
cmd/vela-kubernetes/plugin.go 58.13% <0.00%> (-1.87%) ⬇️
cmd/vela-kubernetes/kubectl.go 84.21% <0.00%> (-0.79%) ⬇️
cmd/vela-kubernetes/apply.go 96.15% <0.00%> (-0.52%) ⬇️
cmd/vela-kubernetes/status.go 96.29% <0.00%> (-0.48%) ⬇️
cmd/vela-kubernetes/patch.go 97.61% <0.00%> (-0.35%) ⬇️
cmd/vela-kubernetes/main.go 0.00% <0.00%> (ø)
cmd/vela-kubernetes/config.go 100.00% <0.00%> (ø)
cmd/vela-kubernetes/command.go 100.00% <0.00%> (ø)
cmd/vela-kubernetes/container.go 100.00% <0.00%> (ø)

Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KellyMerrick KellyMerrick merged commit 40a4c1e into master Sep 30, 2020
@KellyMerrick KellyMerrick deleted the chore/update/pull_policies branch September 30, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants