Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): enable setting path to kubeconfig #33

Merged
merged 1 commit into from
Feb 24, 2020
Merged

feat(config): enable setting path to kubeconfig #33

merged 1 commit into from
Feb 24, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Feb 23, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 23, 2020 22:58
@jbrockopp jbrockopp self-assigned this Feb 23, 2020
@jbrockopp jbrockopp mentioned this pull request Feb 23, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #33 into master will increase coverage by 1.41%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   49.41%   50.82%   +1.41%     
==========================================
  Files           8        8              
  Lines         340      362      +22     
==========================================
+ Hits          168      184      +16     
- Misses        171      177       +6     
  Partials        1        1
Impacted Files Coverage Δ
cmd/vela-kubernetes/main.go 0% <0%> (ø) ⬆️
cmd/vela-kubernetes/config.go 100% <100%> (ø) ⬆️
cmd/vela-kubernetes/command.go 100% <100%> (ø) ⬆️
cmd/vela-kubernetes/status.go 96.77% <100%> (ø) ⬆️
cmd/vela-kubernetes/plugin.go 60% <100%> (ø) ⬆️
cmd/vela-kubernetes/apply.go 96.66% <100%> (+0.23%) ⬆️
cmd/vela-kubernetes/patch.go 97.95% <100%> (+0.08%) ⬆️

@meinenec meinenec merged commit 625d1e2 into master Feb 24, 2020
@meinenec meinenec deleted the feature/config/path branch February 24, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meinenec meinenec meinenec approved these changes

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @kneal @meinenec