Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable setting dry_run for plugin #24

Merged
merged 1 commit into from
Feb 19, 2020
Merged

feat: enable setting dry_run for plugin #24

merged 1 commit into from
Feb 19, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Feb 18, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 18, 2020 21:46
@jbrockopp jbrockopp self-assigned this Feb 18, 2020
kneal
kneal approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@codecov
Copy link

codecov bot commented Feb 18, 2020 •
edited
Loading

Codecov Report

Merging #24 into master will decrease coverage by 1.75%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   53.82%   52.06%   -1.76%     
==========================================
  Files           8        8              
  Lines         301      315      +14     
==========================================
+ Hits          162      164       +2     
- Misses        138      150      +12     
  Partials        1        1
Impacted Files Coverage Δ
cmd/vela-kubernetes/main.go 0% <0%> (ø) ⬆️
cmd/vela-kubernetes/apply.go 96.55% <100%> (+0.12%) ⬆️
cmd/vela-kubernetes/patch.go 97.56% <100%> (+0.06%) ⬆️

@wass3r wass3r merged commit 9565411 into master Feb 19, 2020
@wass3r wass3r deleted the feature/dry_run branch February 19, 2020 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneal kneal kneal approved these changes

@wass3r wass3r wass3r approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @wass3r @kneal