-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dry-run's client/server/none options with backwards compat #139
Conversation
kubectl allows options [client|server|none] instead of just a boolean, starting at some version I'm not sure of. This enables that behavior with a fallback to if the user has passed true or false so folks don't need to update their configurations. I've mapped true->client and false->none but otherwise treating the parameter as a string.
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 60.00% 60.38% +0.38%
==========================================
Files 9 9
Lines 615 621 +6
==========================================
+ Hits 369 375 +6
Misses 244 244
Partials 2 2
|
This getting kinda annoying the Vela logs:
Can this PR get merged and released? |
hey @colindean sorry to review this so late, but it looks great to me, thank you there are a couple tiny linter issues that can be resolved pretty easy so i left some suggestion comments. |
Co-authored-by: dave vader <[email protected]>
lgtm, ty! :D |
kubectl allows options [client|server|none] instead of just a boolean, starting at some version I'm not sure of. This enables that behavior with a fallback to if the user has passed true or false so folks don't need to update their configurations.
I've mapped true->client and false->none but otherwise treating the parameter as a string.
This is the warning seen when running plugin v0.3.0: