Adds --output=yaml to silence deprecation warning

[colindean]

Seen in a run:

WARNING: This version information is deprecated and will be replaced with the
output from kubectl version --short. Use --output=yaml|json to get the full
version.

[colindean]

OK, so hilariously, I ran version --short while testing something else and got this output:

Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.

So, bare version output:

WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.4", GitCommit:"872a965c6c6526caa949f0c6ac028ef7aff3fb78", GitTreeState:"clean", BuildDate:"2022-11-09T13:28:30Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.10", GitCommit:"a7a32748b5c60445c4c7ee904caf01b91f2dbb71", GitTreeState:"clean", BuildDate:"2022-02-16T11:18:16Z", GoVersion:"go1.16.14", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.25) and server (1.21) exceeds the supported minor version skew of +/-1

is being replaced with the --short output:

Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.25.4
Kustomize Version: v4.5.7
Server Version: v1.21.10
WARNING: version difference between client (1.25) and server (1.21) exceeds the supported minor version skew of +/-1

and --short is going away.

Probably the right thing to do instead of adding --short here is to add instead --output=yaml (or json) to get the same information.

clientVersion:
  buildDate: "2022-11-09T13:28:30Z"
  compiler: gc
  gitCommit: 872a965c6c6526caa949f0c6ac028ef7aff3fb78
  gitTreeState: clean
  gitVersion: v1.25.4
  goVersion: go1.19.3
  major: "1"
  minor: "25"
  platform: darwin/arm64
kustomizeVersion: v4.5.7
serverVersion:
  buildDate: "2022-02-16T11:18:16Z"
  compiler: gc
  gitCommit: a7a32748b5c60445c4c7ee904caf01b91f2dbb71
  gitTreeState: clean
  gitVersion: v1.21.10
  goVersion: go1.16.14
  major: "1"
  minor: "21"
  platform: linux/amd64

WARNING: version difference between client (1.25) and server (1.21) exceeds the supported minor version skew of +/-1

[wass3r]

lgtm - thanks!

[codecov]

Codecov Report

Merging #138 (4ab1856) into main (28b6854) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4ab1856 differs from pull request most recent head e70ac5b. Consider uploading reports for the commit e70ac5b to get more accurate results

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   60.00%   60.00%           
=======================================
  Files           9        9           
  Lines         615      615           
=======================================
  Hits          369      369           
  Misses        244      244           
  Partials        2        2           

Impacted Files	Coverage Δ
cmd/vela-kubernetes/command.go	100.00% <100.00%> (ø)

[wass3r]

on second thought, i can check myself, but is this backwards compatible? since we allow for folks to choose their kubectl version, i'd just want to make sure to not cause issues with it causing a failure because the flag isn't supported.

[colindean]

I did not check the compatibility with older versions. I'm not super familiar with how well kubernetes sticks to semver so I just kind of assumed that these options would be available in some way in the entire 1.x series. That may be naively optimistic.

[wass3r]

yea, we don't really have any kind of promise around version compatibility, but a brief check in their docs shows it's supported in 1.21 (https://v1-21.docs.kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#version). their version selector actually only let's you go to 1.22 (which they say is not maintained anymore - https://v1-22.docs.kubernetes.io/docs/home/). i think we're good. thanks.