Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Golangci config update, clean repo, remove changelog #101

Merged
merged 5 commits into from
Mar 8, 2022
Merged

chore: Golangci config update, clean repo, remove changelog #101

merged 5 commits into from
Mar 8, 2022

Conversation

kaymckay
Copy link
Contributor

@kaymckay kaymckay commented Mar 4, 2022

No description provided.

@kaymckay kaymckay self-assigned this Mar 4, 2022
@kaymckay kaymckay requested review from a team March 4, 2022 21:56
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #101 (4f61938) into master (d17806f) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   60.06%   60.00%   -0.07%     
==========================================
  Files           9        9              
  Lines         616      615       -1     
==========================================
- Hits          370      369       -1     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
cmd/vela-kubernetes/config.go 100.00% <ø> (ø)
cmd/vela-kubernetes/kubectl.go 89.18% <ø> (-0.29%) ⬇️
cmd/vela-kubernetes/main.go 0.00% <ø> (ø)
cmd/vela-kubernetes/plugin.go 62.06% <50.00%> (ø)
cmd/vela-kubernetes/patch.go 98.91% <100.00%> (ø)

@kaymckay kaymckay marked this pull request as ready for review March 4, 2022 21:58
KellyMerrick
KellyMerrick approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaymckay kaymckay merged commit dd44140 into master Mar 8, 2022
@kaymckay kaymckay deleted the golangci-cleanup branch March 8, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@JordanSussman JordanSussman JordanSussman approved these changes

Assignees

@kaymckay kaymckay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaymckay @JordanSussman @KellyMerrick