chore(linter): fix linter errors, remove deprecated allow leading spa…

…ces (#165)

.golangci.yml

@@ -42,8 +42,7 @@ linters-settings:
     locale: US
 
   # https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/nolintlint
-  nolintlint:
-    allow-leading-space: true     # allow non-"machine-readable" format (ie. with leading space) 
+  nolintlint: 
     allow-unused: false           # allow nolint directives that don't address a linting issue
     require-explanation: true     # require an explanation for nolint directives
     require-specific: true        # require nolint directives to be specific about which linter is being skipped

cmd/vela-kubernetes/apply_test.go

@@ -26,7 +26,7 @@ func TestKubernetes_Apply_Command(t *testing.T) {
 		Output: "json",
 	}
 
-	// nolint: gosec // testing purposes
+	//nolint:gosec // testing purposes
 	for _, file := range a.Files {
 		want := exec.Command(
 			_kubectl,
@@ -64,7 +64,7 @@ func TestKubernetes_Apply_Command_WithDryRunTrue(t *testing.T) {
 		Output: "json",
 	}
 
-	// nolint: gosec // testing purposes
+	//nolint:gosec // testing purposes
 	for _, file := range a.Files {
 		want := exec.Command(
 			_kubectl,
@@ -102,7 +102,7 @@ func TestKubernetes_Apply_Command_WithDryRunAnythingNonBoolean(t *testing.T) {
 		Output: "json",
 	}
 
-	// nolint: gosec // testing purposes
+	//nolint:gosec // testing purposes
 	for _, file := range a.Files {
 		want := exec.Command(
 			_kubectl,

cmd/vela-kubernetes/command_test.go

@@ -30,7 +30,7 @@ func TestKubernetes_versionCmd(t *testing.T) {
 		Path:      "~/.kube/config",
 	}
 
-	// nolint: gosec // testing purposes
+	//nolint:gosec // testing purposes
 	want := exec.Command(
 		_kubectl,
 		fmt.Sprintf("--kubeconfig=%s", c.Path),

cmd/vela-kubernetes/patch_test.go

@@ -33,7 +33,7 @@ func TestKubernetes_Patch_Command(t *testing.T) {
 		RawContainers: `[{"name": "container", "image": "alpine"}]`,
 	}
 
-	// nolint: gosec // testing purposes
+	//nolint:gosec // testing purposes
 	for _, file := range p.Files {
 		for _, container := range p.Containers {
 			pattern := fmt.Sprintf(patchPattern, container.Name, container.Image)

cmd/vela-kubernetes/status_test.go

@@ -27,7 +27,7 @@ func TestKubernetes_Status_Command(t *testing.T) {
 		Watch:     true,
 	}
 
-	// nolint: gosec // testing purposes
+	//nolint:gosec // testing purposes
 	for _, resource := range s.Resources {
 		want := exec.Command(
 			_kubectl,