Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/spf13/afero to v1.8.0 #3

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 22, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
github.com/spf13/afero require minor v1.6.0 -> v1.8.0

Release Notes

spf13/afero

v1.8.0

Compare Source

  • sftpfs: Add support for Readdirnames and Readdir
  • CacheOnReadFs: Call OpenFile instead of Open in CacheOnReadFs.OpenFile

v1.7.1

Compare Source

v1.7.0

Compare Source

Add experimental GCS support in Afero. Experimental because the CI infra of afero does not test with real GCS buckets.

Limitations:

  • No Chmod support - The GCS ACL could probably be mapped to *nix style permissions but that would add another level of complexity and is ignored in this version.
  • No Chtimes support - Could be simulated with attributes (gcs a/m-times are set implicitly) but that's is left for another version.
  • NOTE: Not thread safe - Also assumes all file operations are done through the same instance of the GcsFs. File operations between different GcsFs instances are not guaranteed to be consistent.

Performance implications

  • Sequential reads are performant
  • Sequential writes are performant.
  • Seek + Read or ReadAt is performant after the initial seek. (produces a warning)
  • Alternating reads/writes to the same file handler are highly inefficient. To get consistent FS behavior using an API that separates readers and writers we close any open readers before an write as well close open writers before a read (ensure the data is committed).
  • Seek + Write such as WriteAt, Truncate, Seek+Write will work as expected but with significant overhead. Doing a seek + write will in effect download the old file/object, overlay it with the new writes and save it back. This is done in a streaming fashion so large files will not clog the memory but will trigger a full download and upload of the file/object.

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner December 22, 2021 12:29
@renovate renovate bot added the dependencies Indicates a change to dependencies label Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #3 (5785d0c) into main (605a80d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   33.60%   33.60%           
=======================================
  Files           6        6           
  Lines         500      500           
=======================================
  Hits          168      168           
  Misses        330      330           
  Partials        2        2           

jbrockopp
jbrockopp previously approved these changes Dec 22, 2021
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renovate renovate bot force-pushed the renovate/github.com-spf13-afero-1.x branch from bef434c to ab3df9a Compare December 23, 2021 03:51
jbrockopp
jbrockopp previously approved these changes Dec 23, 2021
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renovate renovate bot force-pushed the renovate/github.com-spf13-afero-1.x branch from ab3df9a to c9bc451 Compare December 29, 2021 01:04
@renovate renovate bot changed the title fix(deps): update module github.com/spf13/afero to v1.7.0 fix(deps): update module github.com/spf13/afero to v1.7.1 Dec 29, 2021
jbrockopp
jbrockopp previously approved these changes Dec 29, 2021
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renovate renovate bot changed the title fix(deps): update module github.com/spf13/afero to v1.7.1 fix(deps): update module github.com/spf13/afero to v1.8.0 Jan 5, 2022
@renovate renovate bot force-pushed the renovate/github.com-spf13-afero-1.x branch from c9bc451 to cbc571e Compare January 5, 2022 10:45
jbrockopp
jbrockopp previously approved these changes Jan 5, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockopp jbrockopp requested a review from a team January 10, 2022 13:57
@renovate renovate bot force-pushed the renovate/github.com-spf13-afero-1.x branch from cbc571e to 5785d0c Compare January 18, 2022 21:26
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockopp jbrockopp requested a review from a team January 19, 2022 17:56
@wass3r wass3r merged commit 35899b4 into main Jan 19, 2022
@wass3r wass3r deleted the renovate/github.com-spf13-afero-1.x branch January 19, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Indicates a change to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants