Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): use consistent golangci-lint config #160

Merged
merged 5 commits into from
Aug 28, 2024
Merged

fix(lint): use consistent golangci-lint config #160

merged 5 commits into from
Aug 28, 2024

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Aug 25, 2024

copy from go-vela/server config

copy from go-vela/server config
@wass3r wass3r requested a review from a team as a code owner August 25, 2024 06:05
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.98%. Comparing base (1f0058f) to head (c2e393f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   42.98%   42.98%           
=======================================
  Files           7        7           
  Lines         335      335           
=======================================
  Hits          144      144           
  Misses        178      178           
  Partials       13       13           
Files Coverage Δ
cmd/vela-git/main.go 0.00% <ø> (ø)
cmd/vela-git/netrc.go 100.00% <ø> (ø)
cmd/vela-git/plugin.go 48.00% <ø> (ø)
version/version.go 0.00% <ø> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3r wass3r requested review from plyr4 and ecrupper August 27, 2024 16:07
@wass3r wass3r self-assigned this Aug 27, 2024
@wass3rw3rk wass3rw3rk merged commit 5f4337f into main Aug 28, 2024
10 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/lint branch August 28, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants