-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Add ability to attach files to email #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 18.45% 20.93% +2.47%
==========================================
Files 3 3
Lines 428 449 +21
==========================================
+ Hits 79 94 +15
- Misses 346 353 +7
+ Partials 3 2 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments below.
also,
- is this a breaking change?
- we might need attribution for the test image in use depending on where it came from, unless you created it yourself?
@wass3r this isn't a breaking change, and i'm not sure what you mean by attribution but i pulled it off the internet. I can replace it with a target image if needed |
PR for go-vela/community#513
adds ability to attach files to an email. This PR corrects the use of email.Attachment and adds EmailFilename to be the file that contains the contents of the email.