enhance: emit an error when the Auth method is specified but no creds were passed #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a frustrating timeout error when the secrets weren't passed correctly.
colindean
commented
Dec 13, 2022
| Auth: "LoginAuth", | ||
| SMTPHost: &SMTPHost{ | ||
| Host: "smtphost.com", | ||
| Port: "234234", |
There was a problem hiding this comment.
Also LOL this works with an invalid port, that may be a problem if something else doesn't check that
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 20.93% 21.46% +0.52%
==========================================
Files 3 3
Lines 449 452 +3
==========================================
+ Hits 94 97 +3
Misses 353 353
Partials 2 2
|
colindean
commented
Jan 8, 2023
wass3r
approved these changes
Jan 9, 2023
|
Looks like the check failure is just a copyright date. Perhaps that can be done in another PR. |
|
@wass3r Who else can I or you tag to review? |
|
@go-vela/admins should do. I'll bug them tomorrow ;) |
ecrupper
approved these changes
Jan 19, 2023
wass3r
changed the title
wass3r
changed the title
plyr4
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a frustrating timeout error when the secrets weren't passed correctly.