-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize and open source email plugin code #1
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 18.84%
=======================================
Files ? 3
Lines ? 414
Branches ? 0
=======================================
Hits ? 78
Misses ? 333
Partials ? 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, appreciate the optional auth changes.
Correct me if I'm wrong, but I seem to recall someone like @wass3r mentioning that the way that the changelogs are done historically was causing some clashing (& thrashing with overwrites) with using built-in GitHub changelog creation. Do we need to make updates to the workflows to remove that old changelog action and functionality in favor of GitHub's built-in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments on some things, but overall thank you for creating this! Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks for taking the time and effort to make this available for the community.
There were some small nits I included above but they're not show stoppers. I'll approve for now and if you need a re-approval later lemme know.
Adding Initial email code to external repo