Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initialize and open source email plugin code #1

Merged
merged 7 commits into from
Feb 3, 2022
Merged

Conversation

kaymckay
Copy link
Contributor

@kaymckay kaymckay commented Jan 3, 2022

Adding Initial email code to external repo

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@9c2223f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   18.84%           
=======================================
  Files           ?        3           
  Lines           ?      414           
  Branches        ?        0           
=======================================
  Hits            ?       78           
  Misses          ?      333           
  Partials        ?        3           

cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
cmd/vela-email/main.go Outdated Show resolved Hide resolved
cmd/vela-email/defaults.go Outdated Show resolved Hide resolved
cmd/vela-email/defaults.go Outdated Show resolved Hide resolved
cmd/vela-email/loginauth.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin.go Show resolved Hide resolved
cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin_test.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin_test.go Show resolved Hide resolved
cmd/vela-email/plugin_test.go Outdated Show resolved Hide resolved
cmd/vela-email/loginauth.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
@plyr4 plyr4 changed the title Initial email code feat: initialize and open source email plugin code Jan 3, 2022
cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
plyr4
plyr4 previously approved these changes Jan 3, 2022
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

plyr4
plyr4 previously approved these changes Jan 11, 2022
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appreciate the optional auth changes.

@GregoryDosh
Copy link

GregoryDosh commented Jan 18, 2022

Correct me if I'm wrong, but I seem to recall someone like @wass3r mentioning that the way that the changelogs are done historically was causing some clashing (& thrashing with overwrites) with using built-in GitHub changelog creation. Do we need to make updates to the workflows to remove that old changelog action and functionality in favor of GitHub's built-in?

Copy link

@GregoryDosh GregoryDosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments on some things, but overall thank you for creating this! Looks great.

.github/CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin.go Outdated Show resolved Hide resolved
cmd/vela-email/plugin_test.go Outdated Show resolved Hide resolved
cmd/vela-email/main.go Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
GregoryDosh
GregoryDosh previously approved these changes Feb 2, 2022
Copy link

@GregoryDosh GregoryDosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for taking the time and effort to make this available for the community.

There were some small nits I included above but they're not show stoppers. I'll approve for now and if you need a re-approval later lemme know.

@kaymckay kaymckay merged commit 3f36729 into main Feb 3, 2022
@kaymckay kaymckay deleted the email-code branch February 3, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants