Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset favicon in nested layouts #788

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix: reset favicon in nested layouts #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049b05f
fix: reset favicon in nested layouts
plyr4 Apr 2, 2024
f76993d
fix: reset favicon in nested layouts
plyr4 Apr 2, 2024
5207426
Merge branch 'main' into fix/layouts-favicons
plyr4 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/elm/Layouts/Default/Org.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import Route exposing (Route)
import Route.Path
import Shared
import Url exposing (Url)
import Utils.Favicons as Favicons
import Utils.Helpers as Util
import View exposing (View)

Expand Down Expand Up @@ -69,7 +70,10 @@ init : Shared.Model -> Route () -> () -> ( Model, Effect Msg )
init shared route _ =
( { tabHistory = Dict.empty
}
, Effect.getCurrentUser {}
, Effect.batch
[ Effect.updateFavicon { favicon = Favicons.defaultFavicon }
, Effect.getCurrentUser {}
]
)


Expand Down
4 changes: 3 additions & 1 deletion src/elm/Layouts/Default/Repo.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import Route.Path
import Shared
import Time
import Url exposing (Url)
import Utils.Favicons as Favicons
import Utils.Favorites as Favorites
import Utils.Interval as Interval
import View exposing (View)
Expand Down Expand Up @@ -75,7 +76,8 @@ init props shared route _ =
( { tabHistory = Dict.empty
}
, Effect.batch
[ Effect.getCurrentUser {}
[ Effect.updateFavicon { favicon = Favicons.defaultFavicon }
, Effect.getCurrentUser {}
, Effect.getRepoBuildsShared
{ pageNumber = Nothing
, perPage = Nothing
Expand Down
Loading